This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Take 2: Allow printing of 64-bit array sizes in C


On 09/24/2012 01:17 PM, Siddhesh Poyarekar wrote:
> +set testfile "longest-types"
> +set srcfile ${testfile}.c
> +set binfile ${objdir}/${subdir}/${testfile}

These three lines can now be replaced with a single

 standard_testfile

+
> +if { [prepare_for_testing ${testfile}.exp ${testfile}] } {

...

+struct foo
> +{
> +  char buf[0xffff000000];
> +  char buf2[2];
> +} *f;
> +

This will fail to compile on 32-bit targets (size too large), and
the complaint will be verbose on the test run's terminal.  You can make
the failure quiet by passing "quiet" to prepare_for_testing.

Other than that, looks good to me.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]