This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] Delete global param_symbols, unused.
- From: dje at google dot com
- To: gdb-patches at sourceware dot org
- Date: Wed, 19 Sep 2012 13:18:46 -0700
- Subject: [commit] Delete global param_symbols, unused.
Hi.
While debugging a gdb segv with using_directives I came across
param_symbols which is unused.
It was used by hpread.c but that got deleted in 2007.
I can find no use of it today.
Regression tested with amd64-linux.
Committed.
2012-09-19 Doug Evans <dje@google.com>
* buildsym.h (param_symbols): Delete, unused.
(context_stack): Delete member "params", unused.
* buildsym.c (push_context): Update.
* dwarf2read.c (read_func_scope): Update.
Index: buildsym.c
===================================================================
RCS file: /cvs/src/src/gdb/buildsym.c,v
retrieving revision 1.102
diff -u -p -r1.102 buildsym.c
--- buildsym.c 18 Jul 2012 19:59:35 -0000 1.102
+++ buildsym.c 19 Sep 2012 20:03:33 -0000
@@ -1404,14 +1404,12 @@ push_context (int desc, CORE_ADDR valu)
new = &context_stack[context_stack_depth++];
new->depth = desc;
new->locals = local_symbols;
- new->params = param_symbols;
new->old_blocks = pending_blocks;
new->start_addr = valu;
new->using_directives = using_directives;
new->name = NULL;
local_symbols = NULL;
- param_symbols = NULL;
using_directives = NULL;
return new;
Index: buildsym.h
===================================================================
RCS file: /cvs/src/src/gdb/buildsym.h,v
retrieving revision 1.35
diff -u -p -r1.35 buildsym.h
--- buildsym.h 18 Jul 2012 19:59:35 -0000 1.35
+++ buildsym.h 19 Sep 2012 20:03:33 -0000
@@ -120,10 +120,6 @@ EXTERN struct pending *global_symbols;
EXTERN struct pending *local_symbols;
-/* func params local to lexical context */
-
-EXTERN struct pending *param_symbols;
-
/* "using" directives local to lexical context. */
EXTERN struct using_direct *using_directives;
@@ -137,10 +133,6 @@ struct context_stack
struct pending *locals;
- /* Pending func params at the time we entered */
-
- struct pending *params;
-
/* Pending using directives at the time we entered. */
struct using_direct *using_directives;
Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.704
diff -u -p -r1.704 dwarf2read.c
--- dwarf2read.c 12 Sep 2012 18:57:40 -0000 1.704
+++ dwarf2read.c 19 Sep 2012 20:03:34 -0000
@@ -8837,7 +8837,6 @@ read_func_scope (struct die_info *die, s
when we finish processing a function scope, we may need to go
back to building a containing block's symbol lists. */
local_symbols = new->locals;
- param_symbols = new->params;
using_directives = new->using_directives;
/* If we've finished processing a top-level function, subsequent