This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [doc ping] for: Write bpt at the ON_STACK bpt address


> Date: Thu, 13 Sep 2012 07:50:17 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> 
> Hi Eli,
> 
> the gdb/doc/ part remains not committed.
> 
> The patch was the gdb/doc/ part of:
> 	http://sourceware.org/ml/gdb-patches/2012-07/msg00706.html
> your review:
> 	http://sourceware.org/ml/gdb-patches/2012-07/msg00717.html
> my reply to the review:
> 	http://sourceware.org/ml/gdb-patches/2012-07/msg00718.html

Sorry, it looks like I forgot to respond.

> I did not use your rewording of the first paragraph as explained in the last
> mail referenced above.

Re this:

>> On input, the program counter (@code{*@var{pcptr}} is the encoded
>> inferior's PC register.  The function returns the PC's plain address
>> in this argument, or @code{NULL} if software breakpoints are not
>> supported.

To which you responded:

> I do not think that 'pcptr' and 'NULL' should be combined in one
> sentence, these are two topics.

I understand that NULL is the return value of the function, and not
the value of pcptr.  So how about this variant:

 On input, the program counter (@code{*@var{pcptr}} is the encoded
 inferior's PC register.  If software breakpoints are supported, the
 function sets this argument to the PC's plain address.  If software
 breakpoints are not supported, the function returns NULL instead of
 the encoded breakpoint instruction.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]