This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [patch v3 03/16] source: add flags to print_source_lines ()
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "markus dot t dot metzger at gmail dot com" <markus dot t dot metzger at gmail dot com>, "jan dot kratochvil at redhat dot com" <jan dot kratochvil at redhat dot com>, "palves at redhat dot com" <palves at redhat dot com>, "kettenis at gnu dot org" <kettenis at gnu dot org>
- Date: Wed, 12 Sep 2012 08:33:56 +0000
- Subject: RE: [patch v3 03/16] source: add flags to print_source_lines ()
- References: <1344949171-9545-1-git-send-email-markus.t.metzger@intel.com> <1344949171-9545-4-git-send-email-markus.t.metzger@intel.com> <87k3w08gi5.fsf@fleche.redhat.com>
> -----Original Message-----
> From: Tom Tromey [mailto:tromey@redhat.com]
> Sent: Tuesday, September 11, 2012 10:14 PM
> To: Metzger, Markus T
> Cc: gdb-patches@sourceware.org; markus.t.metzger@gmail.com; jan.kratochvil@redhat.com; palves@redhat.com;
> kettenis@gnu.org
> Subject: Re: [patch v3 03/16] source: add flags to print_source_lines ()
>
> >>>>> "Markus" == markus t metzger <markus.t.metzger@intel.com> writes:
>
> Markus> 2012-08-14 Markus Metzger <markus.t.metzger@intel.com>
> Markus> * symtab.h (print_source_lines_flags): New enum.
> Markus> * source.c (print_source_lines_base): Change noerror to flags.
> Markus> (print_source_lines): Change noerror to flags.
>
> This is ok. I think it is fine to put it in immediately if you want.
Thanks. I'll commit patches 1, 3, and 4, then, as soon as I my write-after-approval request has been granted. How about patch 2?
Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Peter Gleissner, Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052