Re: [PATCH 3/3] suppress notification

[Vladimir Prus <ghost at cs dot msu dot su>]

On 31.08.2012 12:07, Yao Qi wrote:
> On 08/28/2012 05:00 AM, Vladimir Prus wrote:
> > > +  /* If non-null, the pointer to a flag indicates that this function
> > > is being
> > > +     called.  */
> > > +  int *called;
> >
> > But in practice, this is pointer that points to notification that must
> > be supressed when this
> > command is running. So, at least the comment is misleading. And if some
> > other code will
> > want to check whether the current command is A, it would have to look at
> > notification
> > flags.
> >
> > So, at the very least, this field should have a different name, I think.
> Vladimir,
> The field name is changed to 'suppress_notification' with some comments
> update.  How about this one?

Yao,

I have no objections to this version.

Thanks,
Volodya