This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC] New GDB Port CR16

From: Mike Frysinger <vapier at gentoo dot org>
To: Kaushik Phatak <Kaushik dot Phatak at kpitcummins dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Yao Qi <yao at codesourcery dot com>
Date: Wed, 29 Aug 2012 18:14:22 -0400
Subject: Re: [RFC] New GDB Port CR16
References: <C6CA53A2A46BA7469348BDBD663AB65845B27868@KCHJEXMB03.kpit.com> <503B9E59.6050502@codesourcery.com> <C6CA53A2A46BA7469348BDBD663AB65845B28084@KCHJEXMB03.kpit.com>

On Tue, Aug 28, 2012 at 10:45 AM, Kaushik Phatak wrote:
> +	    switch(a)

needs a space there:
switch (a)

> +	      case  TRAP_BREAKPOINT:
> +	      case  SIGTRAP:  /* supervisor call ? */

just one space after "case"

also, the comment should have two spaces before the */:
/* Supervisor call ?  */

otherwise looks fine
-mike

Follow-Ups:
- RE: [RFC] New GDB Port CR16
  - From: Kaushik Phatak

References:
- [RFC] New GDB Port CR16
  - From: Kaushik Phatak
- Re: [RFC] New GDB Port CR16
  - From: Yao Qi
- RE: [RFC] New GDB Port CR16
  - From: Kaushik Phatak

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]