Re: [PATCH 08/10] microblaze

[Michael Eager <eager at eagerm dot com>]

On 07/31/2012 11:42 PM, Yao Qi wrote:
> On Tuesday, July 31, 2012 07:44:37 AM Michael Eager wrote:
> > >      /* Debug this files internals.  */
> > >
> > > -  add_setshow_zinteger_cmd ("microblaze", class_maintenance,
> > > -                         &microblaze_debug_flag, _("\
> > > +  add_setshow_zuinteger_cmd ("microblaze", class_maintenance,
> > > +                          &microblaze_debug_flag, _("\
> > >
> > >    Set microblaze debugging."), _("\
> > >    Show microblaze debugging."), _("\
> > >    When non-zero, microblaze specific debugging is enabled."),
> > >
> > > -                         NULL,
> > > -                         NULL,
> > > -                         &setdebuglist, &showdebuglist);
> > > +                          NULL,
> > > +                          NULL,
> > > +                          &setdebuglist, &showdebuglist);
> > >
> > >    }
> >
> > Why is this needed?
>
> Because debug flag should be 'unsigned' and 'add_setshow_zinteger_cmd' has
> been a little bit abused in GDB.  This patch tries to fix it.

This doesn't appear to me to be a necessary change.   The debugging command
works exactly as described.

I'm not clear what abuse of add_setshow_zinteger_cmd you are referring to.
The type of the variable and the type of the function match.

--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077