This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Register commands using add_setshow_zuinteger_cmd
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 30 Jul 2012 11:25:59 -0600
- Subject: Re: [RFC] Register commands using add_setshow_zuinteger_cmd
- References: <1343656692-4247-1-git-send-email-yao@codesourcery.com>
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> I am examing the usage of zuinteger_cmd and zinteger_cmd today, and I find
Yao> that a lot of zinteger_cmd commands should be registered as zuinteger_cmd.
Yao> For example, all the debug commands, such as 'set debug infrun 1' should
Yao> be registered as 'zuinteger_cmd', because we never do 'set debug FOO -2'.
Yao> This patch is not indented to commit anything to CVS, but describe what I
Yao> try to do. If it is the right way to go, I'll convert other zinteger_cmd
Yao> to zuinteger_cmd if appropriate. What do you think?
For 'maint' and 'set debug' settings, I think it is fine.
For other settings, I guess it would depend on the actual benefits of
the change. It seems unlikely that anybody relies on some of these
things. But it also doesn't seem to cause much harm.
Tom