This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/4]: Handle SIGINT under Python by raising KeyboardInterrupt


>>>>> "Yit" == Khoo Yit Phang <khooyp@cs.umd.edu> writes:

Yit> Yes, that's my concern, if immediate_quit is set. As long as that's
Yit> not the case, as you say, then it should be fine.

If immediate_quit is set, then quit will clear the Python exception
before calling longjmp.

immediate_quit should never be set in a context that will call Python.
I agree that would be unsafe.

Yit> An aside: the immediate_quit++ in remote.c doesn't seem to be properly
Yit> paired with immediate_quit--? The latter is only called when non_stop
Yit> is not set.

Yeah, I noticed this the other day and filed a bug for it.

Also, several of the existing sets of immediate_quit enclosing too much
code for my taste.

I think these things are latent bugs in gdb.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]