This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/4]: Make "python" start a standard Python prompt
>>>>> "Yit" == Khoo Yit Phang <khooyp@cs.umd.edu> writes:
Yit> Here's the updated patch that creates a new command
Yit> "python-interactive", aliased to "pi", that starts a standard Python
Yit> REPL; and also aliases "python" to "py".
Looks pretty good to me.
I think it could use a NEWS entry.
Aside from doc review I have a couple of nits -- nothing serious.
Yit> + if (arg && *arg)
Yit> + {
Indentation looks wrong.
Yit> + err = PyRun_InteractiveLoop(instream, "<stdin>");
Space before open paren.
Yit> + if (err)
Yit> + {
Indentation.
The code parts are ok with those formatting fixes.
thanks,
Tom