This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers

From: Tom Tromey <tromey at redhat dot com>
To: Keith Seitz <keiths at redhat dot com>
Cc: gdb-patches ml <gdb-patches at sourceware dot org>, Hui Zhu <teawater at gmail dot com>
Date: Thu, 26 Jul 2012 07:52:37 -0600
Subject: Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
References: <CANFwon22Tt57WcsDE8rPrSjgxg62MbgsN0WrAELu9Y52RDwUGg@mail.gmail.com> <500C0A1F.8040106@redhat.com> <CANFwon2u=xV4XqKV33Fqk_1k7QQQWixMDNNjJKM01tkV4dTWxQ@mail.gmail.com> <87k3xusgan.fsf@fleche.redhat.com> <CANFwon2KzfyOzhV625S7xqMAw6+iLjmUz8oHjaC=T=PUshUZZw@mail.gmail.com> <87lii9ne95.fsf@fleche.redhat.com> <CANFwon0SkNBVcLxf+PqyUzZyQJLhnPPzhPm=9qC9xAO8547Rmw@mail.gmail.com> <50106327.5000004@redhat.com>

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> Ok for HEAD and 7.5?

One nit...

Keith> +      && !isspace(*PARSER_STREAM (parser)) && *PARSER_STREAM (parser) != ','

Space after "isspace".

Ok with that fix, thanks.

Tom

Follow-Ups:
- Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
  - From: Keith Seitz

References:
- [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
  - From: Hui Zhu
- Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
  - From: Keith Seitz
- Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
  - From: Hui Zhu
- Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
  - From: Tom Tromey
- Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
  - From: Hui Zhu
- Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
  - From: Tom Tromey
- Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
  - From: Hui Zhu
- Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
  - From: Keith Seitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]