This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Cannot set pending bp if condition set explicitly


>>>>> "Marc" == Marc Khouzam <marc.khouzam@ericsson.com> writes:

Marc> If I set a condition explicitly on a pending breakpoint (using
Marc> the 'condition' command), the breakpoint fails to install.

Marc> +      /* For a pending breakoint, the condition is not parsed yet */

Comment should end with a period and two spaces.

Marc> +      if (b->loc == NULL || b->loc->shlib_disabled)

I think this ought to use all_locations_are_pending.
But, I am not 100% sure of this.

A test case for this would be quite nice to have.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]