This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix inconsistency in blockvector addrmap vs non-addrmap handling
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org, tromey at redhat dot com, palves at redhat dot com
- Date: Thu, 12 Jul 2012 22:30:23 +0200
- Subject: Re: [RFA] Fix inconsistency in blockvector addrmap vs non-addrmap handling
- References: <20120605011446.670FD1E123B@ruffy2.mtv.corp.google.com> <20120622193539.GA7344@host2.jankratochvil.net> <CADPb22QB0czUev9oKXv9LHHK6H1T=8JhFa0whErojZC+cdrdBw@mail.gmail.com> <20120624183352.GA15915@host2.jankratochvil.net> <CADPb22SDBV_6R17Pndc1SfF7ipyei2VNnQyTz17fWS6Ofeba=A@mail.gmail.com> <20120703125419.GA14860@host2.jankratochvil.net> <CADPb22Q4tEM5N8P88_+Hugx10j20E4O8geH3WBs601Dnuc1AKw@mail.gmail.com>
On Thu, 12 Jul 2012 07:19:30 +0200, Doug Evans wrote:
> I was playing with a case of "pc 0x42 in read in psymtab, but not in
> symtab" case today.
> gdb has other problems that get in the way, but having more
> consistency between partial and full syms has to be a good thing.
Therefore considering it as an agreement/approval of the patch.
Therefore I will check it in tomorrow with no reply.
> [btw, seems kinda odd to have two addrmaps: one for psymtabs/index and
> one for fullsyms. I wonder if there's an opportunity here.]
>
> Here's an updated version of your patch to match the current tree.
>
> 2012-07-11 Jan Kratochvil <jan.kratochvil@redhat.com>
> Doug Evans <dje@google.com>
>
> * buildsym.c (end_symtab_1): Split it to ...
> (end_symtab_get_static_block): ... this ...
> (end_symtab_from_static_block): ... and this function.
> (end_symtab, end_expandable_symtab): Call them.
> * buildsym.h (end_symtab_get_static_block)
> (end_symtab_from_static_block): New declarations.
> * dwarf2read.c (process_full_comp_unit): New variable static_block.
> Set its valid CU ranges.
Thanks,
Jan