This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: New ARI warning Sun Jul 8 01:55:37 UTC 2012
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: GDB Administrator <gdbadmin at sourceware dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 8 Jul 2012 10:53:02 +0200
- Subject: Re: New ARI warning Sun Jul 8 01:55:37 UTC 2012
- References: <20120708015538.GA10693@sourceware.org>
On Sun, 08 Jul 2012 03:55:38 +0200, GDB Administrator wrote:
> 173a174,178
> > gdb/common/linux-ptrace.c:60: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h
> gdb/common/linux-ptrace.c:60:#include <sys/wait.h>
For gdbserver it would:
../common/linux-ptrace.c:57:22: fatal error: gdb_wait.h: No such file or directory
> > gdb/common/linux-ptrace.c:82: regression: strerror: Do not use strerror(), instead use safe_strerror()
> gdb/common/linux-ptrace.c:82: strerror (errno));
> > gdb/common/linux-ptrace.c:94: regression: strerror: Do not use strerror(), instead use safe_strerror()
> gdb/common/linux-ptrace.c:94: strerror (errno));
> > gdb/common/linux-ptrace.c:101: regression: strerror: Do not use strerror(), instead use safe_strerror()
> gdb/common/linux-ptrace.c:101: strerror (errno));
> > gdb/common/linux-ptrace.c:129: regression: strerror: Do not use strerror(), instead use safe_strerror()
> gdb/common/linux-ptrace.c:129: strerror (errno));
safe_strerror has the same problem for gdbserver.
As this is all in Linux-only and even i386-only code I find it both safe.
glibc both accepts NULL for %s and produces "Unknown error 324234234" for
invalid errno. Also errno is there only the system produced one.
I am not aware of non-glibc libcs behavior but it should not be problem.
Regards,
Jan