This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] decode_line_spec_* cleanup


On Thu, Jun 28, 2012 at 2:00 PM, Tom Tromey <tromey@redhat.com> wrote:
> Doug> +struct symtabs_and_lines
> Doug> +decode_line_spec_with_current_source_as_default (char *string, int flags)
> Doug> +{
> [...]
> Doug> + ?/* We use whatever is set as the current source line. ?We do not try
> Doug> + ? ? and get a default ?or it will recursively call us! ?*/
> Doug> + ?cursal = get_current_source_symtab_and_line ();
>
> This seems a little weird since this is already the default.
> In a way this makes the "with_current_source_as_default" more confusing,
> since that does not actually name the difference between this function
> and decode_line_1.

I'm moving things around (and renaming them).  I didn't want to add
any other changes (the text is unchanged from where it was moved
from).
What's meant here by "get a default", I think, is get a default
current source spec.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]