This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: [PATCH 02/16] source: add flags to print_source_lines ()

From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, "kettenis at gnu dot org" <kettenis at gnu dot org>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "markus dot t dot metzger at gmail dot com" <markus dot t dot metzger at gmail dot com>
Date: Mon, 25 Jun 2012 08:50:07 +0000
Subject: RE: [PATCH 02/16] source: add flags to print_source_lines ()
References: <1337772151-20265-1-git-send-email-markus.t.metzger@intel.com> <1337772151-20265-3-git-send-email-markus.t.metzger@intel.com> <20120530204106.GB20633@host2.jankratochvil.net> <A78C989F6D9628469189715575E55B2307A9F022@IRSMSX102.ger.corp.intel.com> <87pq8rf6tk.fsf@fleche.redhat.com>

> -----Original Message-----
> From: Tom Tromey [mailto:tromey@redhat.com]
> Sent: Friday, June 22, 2012 10:08 PM

[...]

> Jan> Make it then 'enum print_source_lines_flags flags'.
> 
> Markus> Flags is intended as bit vector. The enum just gives names to
> Markus> the individual bits.
> 
> In C it is ok to use the enum type the way that Jan suggests; and it
> makes debugging a bit simpler since gdb will print the symbolic value.
> gdb doesn't do this consistently (it doesn't do anything consistently
> :-); but it is nice to do in new code.

It's consistent in that, at least;-)

I pointed out in a reply to Jan already that this won't compile as C++.
I changed it to an enum.

Regards,
Markus.

Attachment: smime.p7s
Description: S/MIME cryptographic signature

--------------------------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland 
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

References:
- Re: [PATCH 02/16] source: add flags to print_source_lines ()
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]