Re: ping: [patch 1/2] Fix gdb.cp/gdb2495.exp regression with gcc-4.7 #5

[Joel Brobecker <brobecker at adacore dot com>]

I took some time to sleep on this...

> >   1. Ignore the initial regression, and release with it
> 
> This is not good, this regresses a nice C++ fixup by Tom.
> 
> 
> >   2. Revert the patch that caused the regression. I can't remember
> >      which patch that was, and whether it would "unsolve" an important
> >      issue.
> 
> The regression is due to binutils fix by Jakub Jelinek:
> 	http://sourceware.org/bugzilla/show_bug.cgi?id=12570
> 
> There is nothing to revert.  The original assumption _start has no unwind info
> was just wrong.  Moreover there was a bug that it relied upon the fact that
> .plt has no unwind info.  But after fixing it to make it really _start (and
> not .plt) some archs (ppc IIRC) has unwind info even for _start.

OK and OK. Thanks for the feedback on these points.

> >   3. Ignore the side-effect/regression caused by this fix, and fix
> >      it later
> 
> Yes, I find it a viable alternative.
> 
> 
> >   4. Delay the release in order to implement setjmp handling.
> 
> I already tried to implement it once but somehow did not finish it.  I do no
> like much that even the longjmps tracking is not a perfect solution.

It seems to me that fixing the problem is going to be quite delicate,
since you keep finding regressions with all the solutions you've been
considering. So I am inclined to accept the regression for 7.5 too.

-- 
Joel