This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix inline frame crash in handle_inferior_event
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 13 Jun 2012 08:55:45 +0200
- Subject: Re: [RFA] Fix inline frame crash in handle_inferior_event
- References: <alpine.DEB.1.10.1206121703180.23962@tp.orcam.me.uk>
On Wed, 13 Jun 2012 07:12:54 +0200, Maciej W. Rozycki wrote:
> 2012-06-13 Maciej W. Rozycki <macro@codesourcery.com>
>
> gdb/
> * infrun.c (handle_inferior_event): Re-fetch frame and gdbarch
> after hiding inline functions.
This is PR backtrace/13866.
> --- gdb-fsf-trunk-quilt.orig/gdb/infrun.c 2012-06-08 23:45:43.000000000 +0100
> +++ gdb-fsf-trunk-quilt/gdb/infrun.c 2012-06-12 08:29:31.063547656 +0100
> @@ -4084,7 +4084,13 @@ handle_inferior_event (struct execution_
> && pc_at_non_inline_function (aspace,
> ecs->event_thread->prev_pc,
> &ecs->ws)))
> - skip_inline_frames (ecs->ptid);
> + {
> + skip_inline_frames (ecs->ptid);
Empty line before comment.
> + /* Re-fetch current thread's frame in case that invalidated
> + the frame cache. */
> + frame = get_current_frame ();
> + gdbarch = get_frame_arch (frame);
> + }
> }
>
> if (ecs->event_thread->suspend.stop_signal == GDB_SIGNAL_TRAP
Yes, fine with me.
Thanks,
Jan