This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] testsuite: XFAIL freebpcmd.exp STABS timeouts


Hi,

with gcc -gstabs or -gstabs+ and i386 target this testcase never worked, the
value of 'i' is random.  With recent local GCC upgrade to Fedora 18 GCC
coincidentally the random value is too large and the testcase started to
timeout.

+"odd "$1 = 1183423
+FAIL: gdb.base/freebpcmd.exp: run program with breakpoint commands (timeout)
+testcase gdb/testsuite/gdb.base/freebpcmd.exp completed in 121 seconds

So XFAIL the case i has invalid value.

Checked in.

tested on {x86_64,x86_64-m32}-fedora18pre-linux-gnu.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2012-06/msg00035.html

--- src/gdb/testsuite/ChangeLog	2012/06/05 13:50:31	1.3213
+++ src/gdb/testsuite/ChangeLog	2012/06/05 19:06:20	1.3214
@@ -1,3 +1,8 @@
+2012-06-05  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* gdb.base/freebpcmd.exp (set lines): Check valid range of I.
+	(run program with breakpoint commands): XFAIl if it is not.
+
 2012-06-05  Joel Brobecker  <brobecker@adacore.com>
 
 	* gdb.base/ctxobj-f.c (GET_VERSION): Introduce local variable
--- src/gdb/testsuite/gdb.base/freebpcmd.exp	2012/01/04 08:17:45	1.15
+++ src/gdb/testsuite/gdb.base/freebpcmd.exp	2012/06/05 19:06:20	1.16
@@ -64,7 +64,10 @@
 # The goal of all this is to make sure that there's plenty of memory
 # churn, and different amounts of it each time the inferior stops;
 # this seems to make GDB crash more reliably.
-set lines {{if (i%2) == 0}
+set lines {{if i<0 || i > 100}
+	   {echo Invalid i value\n}
+	   {else}
+	   {if (i%2) == 0}
            {echo "even "}
            {print i}
            {else}
@@ -81,6 +84,7 @@
            {if i != 40}
            {c}
            {end}
+	   {end}
            {end}}
 
 send_gdb "commands\n"
@@ -114,6 +118,9 @@
     -re "warning: Invalid control type in command structure" {
         kfail "gdb/1489" "run program with breakpoint commands"
     }
+    -re "Invalid i value\r\n$gdb_prompt $" {
+	xfail "run program with breakpoint commands (i value not readable)"
+    }
     -re "$gdb_prompt $" {
         pass "run program with breakpoint commands"
     }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]