This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
> -----Original Message----- > From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com] > Sent: Wednesday, May 30, 2012 10:41 PM > To: Metzger, Markus T Thanks for your review! [...] > > gdb/ > > * symtab.h (print_source_lines_flags): New enum > > * source.c (print_source_lines_base): Change noerror to flags > > (print_source_lines): Change noerror to flags > > The indentation should not be there, just: > > gdb/ > * symtab.h (print_source_lines_flags): New enum. > * source.c (print_source_lines_base): Change noerror to flags. > (print_source_lines): Change noerror to flags. > > And every sentence should be terminated by a dot. Fixed. > > static void > > -print_source_lines_base (struct symtab *s, int line, int stopline, > > int noerror) > > +print_source_lines_base (struct symtab *s, int line, int stopline, > > +int flags) > > Make it then 'enum print_source_lines_flags flags'. Flags is intended as bit vector. The enum just gives names to the individual bits. > > void > > -print_source_lines (struct symtab *s, int line, int stopline, int > > noerror) > > +print_source_lines (struct symtab *s, int line, int stopline, int > > +flags) > > Here again. Same here. > > +/* Flags passed as 4th argument to print_source_lines. */ enum > > +print_source_lines_flags { > > + PRINT_SOURCE_LINES_NOERROR = (0x1 << 0) }; > > GNU Coding Style formatting is (+I changed 0x1, it is just a bit): > > enum print_source_lines_flags > { > PRINT_SOURCE_LINES_NOERROR = (1 << 0) > }; Fixed. Regards, Markus.
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
-------------------------------------------------------------------------------------- Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |