This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Suppress stap-trace.exp when compilation fails
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: "gdb-patches\ at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Wed, 23 May 2012 14:34:12 -0300
- Subject: Re: [RFA] Suppress stap-trace.exp when compilation fails
- References: <4FBD1B16.7080606@redhat.com>
On Wednesday, May 23 2012, Keith Seitz wrote:
> This patch addresses this by fixing the compile wrapper to always
> return a valid value and checking this procedure's return value before
> running the tests.
>
> Okay?
Thanks for catching this.
It's OK for me, but IANAM.
> Keith
>
> testsuite/ChangeLog
>
> 2012-05-23 Keith Seitz <keiths@redhat.com>
>
> * gdb.trace/stap-trace.exp: If compile_stap_bin fails,
> return -1 to suppress the rest of the tests.
> (compile_stap_bin): Return boolean success value.
> diff --git a/gdb/testsuite/gdb.trace/stap-trace.exp b/gdb/testsuite/gdb.trace/stap-trace.exp
> index 562eec4..088d14c 100644
> --- a/gdb/testsuite/gdb.trace/stap-trace.exp
> +++ b/gdb/testsuite/gdb.trace/stap-trace.exp
> @@ -46,8 +46,10 @@ proc compile_stap_bin {exec_name {arg ""}} {
> "$binfile_dir/$exec_name" \
> executable [concat $arg debug nowarnings]] != "" } {
> untested "Could not compile ${srcfile}"
> - return -1
> + return 0
> }
> +
> + return 1
> }
>
> proc prepare_for_trace_test {} {
> @@ -105,7 +107,10 @@ proc gdb_collect_probe_arg { msg probe val_arg0 } {
> "collect $msg: collected probe arg0"
> }
>
> -compile_stap_bin "stap-probe-nosem"
> +if {![compile_stap_bin "stap-probe-nosem"]} {
> + # An appropriate failure message has already been output
> + return -1
> +}
>
> clean_restart $executable
> if { ![runto_main] } {
--
Sergio