This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Emit a warning for ineffective set VAR = EXP command

From: Joel Brobecker <brobecker at adacore dot com>
To: Tristan Gingold <gingold at adacore dot com>
Cc: "Maciej W. Rozycki" <macro at codesourcery dot com>, "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>
Date: Wed, 9 May 2012 07:17:04 -0700
Subject: Re: [RFA] Emit a warning for ineffective set VAR = EXP command
References: <8781499A-A489-42D0-80B1-75136331DBDB@adacore.com> <alpine.DEB.1.10.1205041958130.18334@tp.orcam.me.uk> <EFDD29C9-79FB-468E-B29B-C1783123E41D@adacore.com> <20120507193824.GW15555@adacore.com> <419AD66E-6D21-40D6-97FE-1FF387117B7D@adacore.com>

> I don't know who should approve this adjustment, but here is the
> version that deals with pre/post inc/dec.  Note that it still warns
> for expressions such as i++ * 2.

I think a warning is fine in this case. "set i++ * 2" almost certainly
means something is fishy, because the multiplication is useless.

> 2012-05-09  Tristan Gingold  <gingold@adacore.com>
> 
> 	* printcmd.c (set_command): Add pre/post inc/dec.

This looks good to me.

Thanks Tristan,
-- 
Joel

Follow-Ups:
- Re: [RFA] Emit a warning for ineffective set VAR = EXP command
  - From: Tristan Gingold

References:
- Re: [RFA] Emit a warning for ineffective set VAR = EXP command
  - From: Maciej W. Rozycki
- Re: [RFA] Emit a warning for ineffective set VAR = EXP command
  - From: Tristan Gingold
- Re: [RFA] Emit a warning for ineffective set VAR = EXP command
  - From: Joel Brobecker
- Re: [RFA] Emit a warning for ineffective set VAR = EXP command
  - From: Tristan Gingold

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]