This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Microblaze simulator - Fix missing prototype
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Joel Sherrill <joel dot sherrill at oarcorp dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Tue, 08 May 2012 02:21:03 -0300
- Subject: Re: Microblaze simulator - Fix missing prototype
- References: <4FA82F46.4080901@oarcorp.com>
Hi Joel,
Same comment from last e-mail: please send the patches to
gdb-patches@sourceware.org. I am replying this e-mail to the
appropriate list, with comments about your patch, but please send other
patches to that list.
On Monday, May 07 2012, Joel Sherrill wrote:
> Without this patch, this generates a missing prototype
> warning which is treated as an error. I don't see this
> routine referenced elsewhere, so there is the possibility
> that it also could be made static.
The `_initialize*' routines are treated specially by the Makefile, when
you build the project. They cannot be made static because they are
called from another source file. Take a look at gdb/Makefile.in, and
search for the rule `init.c:'.
> OK to apply?
Small nit below.
> Index: gdb/microblaze-rom.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/microblaze-rom.c,v
> retrieving revision 1.5
> diff -u -r1.5 microblaze-rom.c
> --- gdb/microblaze-rom.c 4 Jan 2012 08:17:06 -0000 1.5
> +++ gdb/microblaze-rom.c 7 May 2012 20:15:54 -0000
> @@ -25,6 +25,8 @@
> #include "serial.h"
> #include "regcache.h"
>
> +void _initialize_picobug_rom(void);
There should be a space between the function name and the open paren.
I am not a maintainer, but this change seems pretty trivial to me so
that it can be committed without an explicit approval.
Thanks,
--
Sergio