This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Improved linker-debugger interface
On Monday, May 07 2012, Jan Kratochvil wrote:
> On Fri, 04 May 2012 17:21:29 +0200, Gary Benson wrote:
>> diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
>> index 69d3cb5..4897d51 100644
>> --- a/gdb/solib-svr4.c
>> +++ b/gdb/solib-svr4.c
>> @@ -47,6 +47,8 @@
>> #include "auxv.h"
>> #include "exceptions.h"
>>
>> +#include "stap-probe.h"
>
> Generic GDB code should only include "probe.h", not "stap-probe.h", so that
> the probes can be of arbitrary kind.
>
> It also no longer built with FSF GDB HEAD:
> solib-svr4.c: In function âsvr4_update_solib_event_breakpointâ:
> solib-svr4.c:1463:33: error: dereferencing pointer to incomplete type
>
> but it gets fixed just by:
>
> -#include "stap-probe.h"
> +#include "probe.h"
FYI, this is because of:
http://sourceware.org/ml/gdb-cvs/2012-05/msg00035.html
Which I have committed just after reviewing Gary's patch.
--
Sergio