This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 1/2] mips: Switch inferior function calls to ON_STACK method.


> Date: Sat, 5 May 2012 00:25:04 +0100
> From: "Maciej W. Rozycki" <macro@codesourcery.com>
>
> > > +/* Implement the push_dummy_code gdbarch method for mips targets.  */
> > 
> > Perhaps change that comment into:
> > 
> >   /* Implement the "push_dummy_call" gdbarch method.  */
> > 
> > such that it is consistent with the style of comments in rl78-tdep.c
> > and rx-tdep.c and moxie-tdep.c?  The "for mips targets" isn't really
> > adding any information (and might end up accidentally being copied).
> 
>  As per my suggestion I think it makes sense to document any peculiarities 
> of this specific implementation here as well (in this case the safety to 
> use with non-executable stack).

The non-executable stack issue really isn't specific to this
implementation though.  On OpenBSD the stack is non-executable on all
architectures where it is possible (including through a clever trick
on i386).  I haven't tried ON_STACK on all of them, but it works on
all of them.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]