This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag)
On Tuesday, April 24 2012, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> There's no need to commit all this in one go. Once you split,
> Pedro> some of the resulting patches will be dead obvious, and will end up
> Pedro> reviewed (if even necessary) and checked in quickly, and thus you end up
> Pedro> making progress faster that way.
>
> It seems to me that a variable that is declared but not initialized and
> not used is always going to be obviously dead. I'd be comfortable with
> pre-approving all such removals; leaving review for the patches to the
> generators and initialized variables.
Thanks for the reviews, guys. If you approve the obvious
non-initialized bits, I'll gladly commit it (except for dwarf2read.c
changes, as Doug asked).
--
Sergio