Re: [PATCH] Add support for Tilera TILE-Gx processor (part 1/2: gdb)

[Pedro Alves <palves at redhat dot com>]

On 04/23/2012 08:58 PM, Jeff Kenton wrote:

> diff -r -u -N /home/packages/gdb-7.4x/gdb/config/tilegx/tm-linux.h ./gdb/config/tilegx/tm-linux.h
> --- /home/packages/gdb-7.4x/gdb/config/tilegx/tm-linux.h	1969-12-31 19:00:00.000000000 -0500
> +++ ./gdb/config/tilegx/tm-linux.h	2012-04-23 13:01:20.342909000 -0400
> @@ -0,0 +1,29 @@
> +/* Target-dependent definitions for GNU/Linux TILE.
> +
> +   Copyright (C) 2012 Free Software Foundation, Inc.
> +
> +   This file is part of GDB.
> +
> +   This program is free software; you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation; either version 3 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
> +
> +#ifndef TM_TILELINUX_H
> +#define TM_TILELINUX_H
> +
> +/* Pull in GNU/Linux generic defs.  */
> +#include "config/tm-linux.h"
> +
> +/* Integer capable of holding an instruction bundle.  */
> +typedef unsigned long long t_bundle;
> +
> +#endif /* TM_TILELINUX_H */


tm files are long gone from GDB's sources.  This whole file is dead -- note
config/tm-linux.h doesn't exist.

Could you please split the series further one more time (and resubmit
as a new thread, not as a reply to this one)?  I'd like to see the host-independent
tdep bits split out from the linux native debugger support (the nat bits).  So you'll
end up with 3 patches (you should be able to debug against gdbserver with just
the tdep bits, and the gdbserver bits, for example.).  That'll make it easier to see
such issues and what else might need adjustment to current GDB's way of doing things.

-- 
Pedro Alves