Re: [PATCH] Remove board setting `gdb,cannot_call_functions'

[Pedro Alves <palves at redhat dot com>]

On 04/23/2012 11:34 AM, Yao Qi wrote:

> Hi,
> When documenting all exiting board settings we are using,
> `gdb,cannot_call_functions' is interesting to me.  What does
> `gdb,cannot_call_functions' mean?  Can't do inf-call?


Yes.

>From upstream DejaGNU's baseboards:

>grep cannot_call_functions * -C 1
arm-ice.exp-# Can't call functions from GDB.
arm-ice.exp:set_board_info gdb,cannot_call_functions 1
arm-ice.exp-
--
moxie-sim.exp-set_board_info gdb,noresults 1
moxie-sim.exp:set_board_info gdb,cannot_call_functions 1
moxie-sim.exp-set_board_info gdb,skip_float_tests 1
--
powerpcle-sim.exp-# Can't call functions from GDB.
powerpcle-sim.exp:set_board_info gdb,cannot_call_functions 1
--
powerpc-sim.exp-# Can't call functions from GDB.
powerpc-sim.exp:# set_board_info gdb,cannot_call_functions 1
--
sh-hms.exp-# And it can't call functions.
sh-hms.exp:set_board_info gdb,cannot_call_functions  1
sh-hms.exp-


The powerpc-sim ones could still be relevant, and tested, I suppose.  It could
be the reason that functions couldn't (or can't)  be called with these targets was
related to the target backend, not the tdep code in gdb.  Or, this might useful while
still developing a new port.  E.g., moxie is a new-ish port, where Anthony Green
added that "gdb,cannot_call_functions" as recently as 2010:

https://lists.gnu.org/archive/html/dejagnu/2010-01/msg00000.html

Of course, that might have been blind copy&paste.

I think that even if we removed the support, we should still minimally document
the variable though...  If we add something like this in the future,
we'd want to reuse the old name.  But if this isn't getting in the way...

> It is quite impossible that someone is still setting

> `gdb,cannot_call_functions' in his/her board file, I assume.  However,
> I might be wrong.


-- 
Pedro Alves