Re: [RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag)

[Doug Evans <dje at google dot com>]

On Mon, Apr 23, 2012 at 3:51 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> Hi,
>
> This patch is a followup of the discussion in:
>
> ? ?http://sourceware.org/ml/gdb/2012-04/msg00171.html
>
> First of all, I am sorry for the size of this patch, but I couldn't
> think of a good way of splitting it, and also I thought it would be
> useless since these changes are all logically related.
>
> I regtested the patch on a Fedora 16 x86{,_64}, without regressions. ?I
> also built the patch using `--enable-targets=all --enable-plugins
> --enable-gold', and everything succeeded.
>
> I'd like to apply it, but I have a couple of questions before:
>
> a) How's the ChangeLog for this patch supposed to be? ?Can I make a
> "generic" ChangeLog, saying something like `Remove unused variables from
> files'?
>
> b) I'd like someone to take a look at the `observer.sh' change, please.
>
> Thank you,

Hi.  Can we hold off these kinds of changes to dwarf2read.c?

ref: Fission patch set