This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add x32 XML files


On Thu, Apr 12, 2012 at 8:11 AM, Tom Tromey <tromey@redhat.com> wrote:
> HJ> I am checking in this and I will submit other x32 patches.
>
> That is not our process.
>
> If you got an approval off-list, that is fine, but please say so.
>
> If you didn't; well, it isn't ok to check things in, unless they are
> obvious.
>
> Tom

Mark's exact words are

---
Unfortunately that will mean that something like print $rip will
behave differently and no longer prints something that's recognizable
as a code address.  I guess using core_ptr while specifying bitsize as
64 horribly fails?

IIRC the amd64 architecture has no possibility to silently ignore the
upper 32 bits in the $rip register, which probably means that if you
ever end up with those being set the program will crash.  So I guess
you want to be able to look at those bits inside GDB.  If you create
$eip and $ebp/$esp pseudo-registers that use core_ptr and data_ptr,
then I gues we could live with $rip and $rbp/$rsp being "naked" 64-bit
values.  In that case your diff makes sense to me, although I'm not an
expert on the tdesc stuff.
---

I take it as approval.


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]