This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add bp_location to Python interface
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Kevin Pouget <kevin dot pouget at gmail dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org, Eli Zaretskii <eliz at gnu dot org>
- Date: Tue, 03 Apr 2012 13:15:02 +0100
- Subject: Re: [PATCH] Add bp_location to Python interface
- References: <CAPftXUL7Gag8pOzh6NF2t=nowBgSYa_Je3CkMQHgxexrNz+OHg@mail.gmail.com> <m3liqn9lym.fsf@redhat.com> <CAPftXULeNBNLT=9EixD3sEdtxcLkRuUFY6ny=2k9NSUQqHf+Bg@mail.gmail.com> <m3k4656dkx.fsf@redhat.com> <CAPftXU+NjNead1ZHEc8_P84py3esmOnAKVa2Y1KpxKX_augKsw@mail.gmail.com> <CAPftXUL6KTe-WEFnWR38pVnGUJhmEQgZ0J7R7heeR3GHtmrf5g@mail.gmail.com> <83r4z8eqoa.fsf@gnu.org> <CAPftXULwT9pTagJOzVsDjtdFkcoFwTWm3gs0=a=EYzMbZYHPgA@mail.gmail.com> <CADPb22Sj1SmW0u+usg6FfmrteOuv7inQWgd8YqxdMCuaH=KHdg@mail.gmail.com> <CAPftXU+R6kZqwF0ZFhc_dBQW54z__581rgLgbift3DcGLcCLhA@mail.gmail.com> <CADPb22RTZmwQ3VsrYYw--o=qUp+3_FOT6Sx6BU5dkcP9uGKmkw@mail.gmail.com> <CAPftXUJuT+m1G+9UGkzPpzo=rps2RMxXZkDVnUh17i9-G3YYgw@mail.gmail.com> <87zkaxn9zf.fsf@fleche.redhat.com> <CAPftXUJ4VqDsadmWYZ39qpyGd7UAV1G3iHkDkWkVKqyxGnSCqg@mail.gmail.com>
> On Fri, Mar 30, 2012 at 9:51 PM, Tom Tromey <tromey@redhat.com>
> wrote:
> On 04/03/2012 11:34 AM, Kevin Pouget wrote:
> the idea here was that a tuple is not mutable, whereas a list is --
> () vs. []. I've removed the tuple, although although I'm not sure
> when I'm supposed to use the List or the Tuple.
This was my comment way back when, so apologies for the conflicting
comments. I prefer to return non-mutable objects when they reflect an
internal state of GDB; just to provide a hint that the data exchange
is one-way -- that changing the list won't change state back in GDB
(hence the immutable tuple).
Though I suspect it does not really matter -- the user can quite
easily turn a tuple into a list. As for returning a tuple versus a
list, again, I guess it does not really matter; the tuple idiom
was just my convention (though with very large lists, the conversion
to a tuple might be expensive).
> 2012-03-04 Kevin Pouget <kevin.pouget@st.com>
>
> Add bp_location to Python interface
> * Makefile.in (SUBDIR_PYTHON_OBS): Add py-bploc.o
> (SUBDIR_PYTHON_SRCS): Add python/py-bploc.c
> Add build rule for this file.
> * breakpoint.h (struct bploc_object): Forward declaration.
> (struct bp_location): Add py_bploc_obj.
> * python/py-bploc.c: New file.
> * python/py-breakpoint.c (bppy_locations): New function.
> (breakpoint_object_methods): New method binding: locations().
> * python/python-internal.h (bploc_object): New typedef.
> (bplocation_to_bplocation_object): New prototype.
> (gdbpy_initialize_bplocation): Likewise.
>
> doc/
> Add bp_location to Python interface
> * gdb.texinfo (Breakpoints In Python): Document
> gdb.Breakpoint.locations and gdb.BpLocation.
>
>
> testsuite/
> Add bp_location to Python interface
> * gdb.python/py-breakpoint.exp: Test gdb.BpLocation.
Thanks for this,
Cheers
Phil