This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] sim: make sure to include strsignal prototype

From: Mike Frysinger <vapier at gentoo dot org>
To: gdb-patches at sourceware dot org
Cc: "Hans-Peter Nilsson" <hp at bitrange dot com>
Date: Sat, 24 Mar 2012 01:33:49 -0400
Subject: Re: [PATCH] sim: make sure to include strsignal prototype
References: <1332476592-12930-1-git-send-email-vapier@gentoo.org> <alpine.BSF.2.00.1203230114540.31229@dair.pair.com> <201203231143.18540.vapier@gentoo.org>

On Friday 23 March 2012 11:43:17 Mike Frysinger wrote:
> On Friday 23 March 2012 01:24:07 Hans-Peter Nilsson wrote:
> > Another thing I noticed: could you please adjust the
> > sim/testsuite/sim/cris/c/ tests too?  Lots of "program stopped
> > with signal" there; your earlier fixes seems to have been just
> > to the asm/ subdir.
> 
> i fixed the ones that failed when i did `make check-sim`.  wasn't ignoring
> the other ones, just didn't notice.  i can fix them up too.

committed the patch below
-mike

2012-03-24  Mike Frysinger  <vapier@gentoo.org>

	* c/clone5.c: Update output to ignore decoded signal string.
	* c/fcntl1.c, c/kill2.c, c/kill3.c, c/mprotect1.c, c/pipe5.c,
	c/readlink5.c, c/rtsigprocmask1.c, c/rtsigsuspend1.c, c/sig10.c,
	c/sig11.c, c/sig3.c, c/sig4.c, c/sig5.c, c/sig6.c, c/sig7.c,
	c/sig8.c, c/sigreturn1.c, c/sigreturn2.c, c/syscall1.c,
	c/syscall2.c, c/syscall3.c, c/syscall4.c, c/sysctl2.c: Likewise.

--- sim/testsuite/sim/cris/c/clone5.c
+++ sim/testsuite/sim/cris/c/clone5.c
@@ -2,7 +2,7 @@
 #notarget: cris*-*-elf
 #xerror:
 #output: Unimplemented clone syscall *
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 
 #include <stddef.h>
--- sim/testsuite/sim/cris/c/fcntl1.c
+++ sim/testsuite/sim/cris/c/fcntl1.c
@@ -2,7 +2,7 @@
 #notarget: cris*-*-elf
 #xerror:
 #output: Unimplemented fcntl*
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 #include <fcntl.h>
 #include <stdio.h>
--- sim/testsuite/sim/cris/c/kill2.c
+++ sim/testsuite/sim/cris/c/kill2.c
@@ -1,6 +1,6 @@
 /* Basic kill functionality test; suicide.
 #xerror:
-#output: program stopped with signal 6.\n
+#output: program stopped with signal 6 (*).\n
 */
 
 #include <stdio.h>
--- sim/testsuite/sim/cris/c/kill3.c
+++ sim/testsuite/sim/cris/c/kill3.c
@@ -1,6 +1,6 @@
 /* Basic kill functionality test; suicide.
 #xerror:
-#output: program stopped with signal 6.\n
+#output: program stopped with signal 6 (*).\n
 */
 
 #include <stdio.h>
--- sim/testsuite/sim/cris/c/mprotect1.c
+++ sim/testsuite/sim/cris/c/mprotect1.c
@@ -2,7 +2,7 @@
 #notarget: cris*-*-elf
 #xerror:
 #output: Unimplemented mprotect call (0x0, 0x2001, 0x4)\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
  */
 #include <stdlib.h>
 #include <stdio.h>
--- sim/testsuite/sim/cris/c/pipe5.c
+++ sim/testsuite/sim/cris/c/pipe5.c
@@ -2,7 +2,7 @@
 #notarget: cris*-*-elf
 #xerror:
 #output: Terminating simulation due to writing pipe * from one single thread\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 #include <stddef.h>
 #include <signal.h>
--- sim/testsuite/sim/cris/c/readlink5.c
+++ sim/testsuite/sim/cris/c/readlink5.c
@@ -3,6 +3,6 @@
 #dest: ./readlink5.c.x
 #xerror:
 #output: Unimplemented readlink syscall (*)\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 #include "readlink2.c"
--- sim/testsuite/sim/cris/c/rtsigprocmask1.c
+++ sim/testsuite/sim/cris/c/rtsigprocmask1.c
@@ -3,7 +3,7 @@
 #cc: additional_flags=-pthread
 #xerror:
 #output: Unimplemented rt_sigprocmask syscall (0x3, 0x0, 0x3dff*\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 
    Testing a signal handler corner case.  */
 
--- sim/testsuite/sim/cris/c/rtsigsuspend1.c
+++ sim/testsuite/sim/cris/c/rtsigsuspend1.c
@@ -2,7 +2,7 @@
 #notarget: cris*-*-elf
 #xerror:
 #output: Unimplemented rt_sigsuspend syscall arguments (0x1, 0x2)\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 
 #include <unistd.h>
--- sim/testsuite/sim/cris/c/sig10.c
+++ sim/testsuite/sim/cris/c/sig10.c
@@ -3,7 +3,7 @@
 #cc: additional_flags=-pthread
 #xerror:
 #output: Exiting pid 42 due to signal 9\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 
 #include <stdlib.h>
--- sim/testsuite/sim/cris/c/sig11.c
+++ sim/testsuite/sim/cris/c/sig11.c
@@ -3,7 +3,7 @@
 #cc: additional_flags=-pthread
 #xerror:
 #output: Unimplemented signal: 77\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 
 #include <stdlib.h>
--- sim/testsuite/sim/cris/c/sig3.c
+++ sim/testsuite/sim/cris/c/sig3.c
@@ -1,6 +1,6 @@
 /* Check that TRT happens at an abort (3) call, single thread.
 #xerror:
-#output: program stopped with signal 6.\n
+#output: program stopped with signal 6 (*).\n
 */
 
 #include <stdlib.h>
--- sim/testsuite/sim/cris/c/sig4.c
+++ sim/testsuite/sim/cris/c/sig4.c
@@ -3,7 +3,7 @@
 #cc: additional_flags=-pthread
 #xerror:
 #output: Exiting pid 42 due to signal 6\n
-#output: program stopped with signal 6.\n
+#output: program stopped with signal 6 (*).\n
 */
 
 #include <stdlib.h>
--- sim/testsuite/sim/cris/c/sig5.c
+++ sim/testsuite/sim/cris/c/sig5.c
@@ -1,7 +1,7 @@
 /* Check that TRT happens for an uncaught non-abort signal, single thread.
 #xerror:
 #output: Unimplemented signal: 7\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 
 #include <stdlib.h>
--- sim/testsuite/sim/cris/c/sig6.c
+++ sim/testsuite/sim/cris/c/sig6.c
@@ -3,7 +3,7 @@
 #cc: additional_flags=-pthread
 #xerror:
 #output: Exiting pid 42 due to signal 7\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 
 #include <stdlib.h>
--- sim/testsuite/sim/cris/c/sig7.c
+++ sim/testsuite/sim/cris/c/sig7.c
@@ -2,7 +2,7 @@
 #notarget: cris*-*-elf
 #xerror:
 #output: Unimplemented rt_sigaction syscall (0x8, 0x3df*\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 #include <stdio.h>
 #include <signal.h>
--- sim/testsuite/sim/cris/c/sig8.c
+++ sim/testsuite/sim/cris/c/sig8.c
@@ -1,7 +1,7 @@
 /* Check that TRT happens for an ignored catchable signal, single thread.
 #xerror:
 #output: Unimplemented signal: 14\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 
    Sure, it'd probably be better to support signals in single-thread too,
    but that's on an as-need basis, and I don't have a need for it yet.  */
--- sim/testsuite/sim/cris/c/sigreturn1.c
+++ sim/testsuite/sim/cris/c/sigreturn1.c
@@ -2,7 +2,7 @@
 #notarget: cris*-*-elf
 #xerror:
 #output: Invalid sigreturn syscall: no signal handler active (0x1, 0x2, 0x3, 0x4, 0x5, 0x6)\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 
 #include <unistd.h>
--- sim/testsuite/sim/cris/c/sigreturn2.c
+++ sim/testsuite/sim/cris/c/sigreturn2.c
@@ -3,7 +3,7 @@
 #cc: additional_flags=-pthread
 #xerror:
 #output: Invalid sigreturn syscall: no signal handler active (0x1, 0x2, 0x3, 0x4, 0x5, 0x6)\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 
 #include <stdlib.h>
--- sim/testsuite/sim/cris/c/syscall1.c
+++ sim/testsuite/sim/cris/c/syscall1.c
@@ -2,7 +2,7 @@
 #notarget: cris*-*-elf
 #xerror:
 #output: Unimplemented syscall: 166 (0x1, 0x2, 0x3, 0x4, 0x5, 0x6)\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 
 #include <unistd.h>
--- sim/testsuite/sim/cris/c/syscall2.c
+++ sim/testsuite/sim/cris/c/syscall2.c
@@ -2,7 +2,7 @@
 #notarget: cris*-*-elf
 #xerror:
 #output: Unimplemented syscall: 0 (0x3, 0x2, 0x1, 0x4, 0x6, 0x5)\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 
 #include <unistd.h>
--- sim/testsuite/sim/cris/c/syscall3.c
+++ sim/testsuite/sim/cris/c/syscall3.c
@@ -3,7 +3,7 @@
 #sim: --cris-unknown-syscall=stop
 #xerror:
 #output: Unimplemented syscall: 166 (0x1, 0x2, 0x3, 0x4, 0x5, 0x6)\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 
 #include "syscall1.c"
--- sim/testsuite/sim/cris/c/syscall4.c
+++ sim/testsuite/sim/cris/c/syscall4.c
@@ -3,7 +3,7 @@
 #sim: --cris-unknown-syscall=stop
 #xerror:
 #output: Unimplemented syscall: 0 (0x3, 0x2, 0x1, 0x4, 0x6, 0x5)\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 */
 
 #include "syscall2.c"
--- sim/testsuite/sim/cris/c/sysctl2.c
+++ sim/testsuite/sim/cris/c/sysctl2.c
@@ -1,7 +1,7 @@
 /* Check error message for invalid sysctl call.
 #xerror:
 #output: Unimplemented _sysctl syscall *\n
-#output: program stopped with signal 4.\n
+#output: program stopped with signal 4 (*).\n
 #notarget: cris*-*-elf
 */

Attachment: signature.asc
Description: This is a digitally signed message part.

References:
- [PATCH] sim: make sure to include strsignal prototype
  - From: Mike Frysinger
- Re: [PATCH] sim: make sure to include strsignal prototype
  - From: Hans-Peter Nilsson
- Re: [PATCH] sim: make sure to include strsignal prototype
  - From: Mike Frysinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]