This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add dll trampoline code handling for windows 64bit
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Roland Schwingel <roland dot schwingel at onevision dot com>, gdb-patches at sourceware dot org
- Date: Thu, 15 Mar 2012 08:27:00 -0600
- Subject: Re: [PATCH] Add dll trampoline code handling for windows 64bit
- References: <4F610188.5010001@onevision.com> <20120314210310.GJ2853@adacore.com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> That is very odd, the script should indeed indent the sources
Joel> in a way that follows the GNU Coding Standards. Perhaps we are
Joel> missing some parameters in the call to that script that override
Joel> certain defaults that may no longer match our standards.
When I looked at this for GCC, some years ago now, GNU indent did not
have all the needed options to really mimic GNU style as actually used.
I would like it if we could use some indentation tool.
This would remove a lot of drudgery from patch review.
But, this would require someone doing an investigation into the existing
tools to see if they can do the job. Maybe GNU indent is better now
(though I never heard a response to my various bug reports); or maybe
uncrustify (http://uncrustify.sourceforge.net/) is good enough.
Right now, unless someone volunteers to do the above, I think we should
remove gdb_indent.sh as being actively confusing.
Here's a starting point for uncrustify:
http://debbugs.gnu.org/db/63/6318.html
This bug has a GNU-ish config file attached.
Tom