This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Refactor internal variable mechanism
- From: Tom Tromey <tromey at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 09 Mar 2012 14:03:41 -0700
- Subject: Re: [PATCH 1/3] Refactor internal variable mechanism
- References: <m3boo5cyd8.fsf@redhat.com> <m3ty1xbjnh.fsf@redhat.com>
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> This is the first patch, which refactors the internal variable
Sergio> mechanism. It creates new methods, for example to compile an internal
Sergio> variable into agent expression.
Sergio> Is this OK to check-in?
I intend to approve this one but I would like to wait for other comments
first.
Really I'm replying now to point out a nit :)
Sergio> +/* Implementation of `thread' variable. */
Sergio> +
Sergio> +static struct internalvar_funcs thread_funcs =
This one should be 'const' like the others are.
Tom