This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix PR 13392 : check offset of JMP insn
- From: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Tue, 06 Mar 2012 21:14:39 +0100
- Subject: Re: [patch] Fix PR 13392 : check offset of JMP insn
- References: <4F561363.4070702@codesourcery.com> <4F56434F.4030107@redhat.com>
On Tue, 2012-03-06 at 17:03 +0000, Pedro Alves wrote:
> We should send an error back to GDB with "E." instead of printing something
> to gdbserver's console, and leaving the user with a generic and
> unhelful error. "4-byte" isn't strictly correct, as this is a signed
> offset, and I think we can be a bit more clear. So we end up with:
>
> sprintf (err,
> "E.Jump back from jump pad too far from tracepoint "
> "(offset 0x%" PRIx64 " > int32).", loffset);
>
In the gdb protocol documentation, all error replies but one
are described as E NN. Some of them specifies that NN are
hex digits.
The exception is the packet qTMinFTPILen:
the error reply is described as only an E
(this last sentence intentionnally not finished with a . :).
Is there somewhere a description of what an E. packet is,
and when this is allowed ?
Philippe