This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch/testsuite/gdbserver] unsuspend lwps after step over
Thanks. This is okay, with one nit.
On 02/29/2012 04:17 AM, Yao Qi wrote:
> +if { [gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile \
> + executable [list debug $additional_flags] ] != "" } {
> + untested itset.exp
Not itset.exp :-).
I never really understood why we tend to put the test name in untested
calls; we end just up with the test name duplicated:
UNTESTED: gdb.threads/current-lwp-dead.exp: current-lwp-dead.exp
UNTESTED: gdb.threads/gcore-thread.exp: gcore-thread.exp
I'd rather we spelled out the _reason_ why the test was untested.
So I suggest instead something like:
untested "Couldn't compile test program"
Unfortunately, we do have a _lot_ of instances to fix:
$ grep -rn "untested.*\.exp" * | wc -l
509
But I think we should stop adding more.
--
Pedro Alves