This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/9] move agent related code from gdbserver to common/agent.c

From: Pedro Alves <palves at redhat dot com>
To: Yao Qi <yao at codesourcery dot com>
Cc: gdb-patches at sourceware dot org
Date: Thu, 23 Feb 2012 21:04:46 +0000
Subject: Re: [PATCH 1/9] move agent related code from gdbserver to common/agent.c
References: <1329447300-18841-1-git-send-email-yao@codesourcery.com> <1329447300-18841-2-git-send-email-yao@codesourcery.com> <4F46A923.1090005@redhat.com>

On 02/23/2012 09:01 PM, Pedro Alves wrote:

argh, a sign that I probably shouldn't be reviewing at this late hour.  I meant,

> Something fishy with the indentation here.  Make entries and indented

Make sure entries are indented with one tab.

> breakpoint (e.g., a breakpoint at write/read, or a catch system),

or a catch syscall.

-- 
Pedro Alves

References:
- [patch v2] GDB/GDBserver talks with agents
  - From: Yao Qi
- [PATCH 1/9] move agent related code from gdbserver to common/agent.c
  - From: Yao Qi
- Re: [PATCH 1/9] move agent related code from gdbserver to common/agent.c
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]