This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc target-side break conditions 3/5 v2] GDB-side changes


BTW,

On 02/07/2012 11:15 AM, Luis Gustavo wrote:
> +/* Returns true if BPT is a breakpoint of any kind.  */

This is ambiguous, because "breakpoint" can mean all kinds of breakpoints,
watchpoints, tracepoints, whateverpoints.

Witness:

 /* This is for all kinds of breakpoints.  */

 struct breakpoint
 {

Best be a bit more explicit.

> +
> +extern int is_breakpoint (const struct breakpoint *bpt);

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]