This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/commit] Rename la_get_symbol_name_match_p into la_get_symbol_name_cmp
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 30 Jan 2012 08:00:53 +0100
- Subject: Re: [RFA/commit] Rename la_get_symbol_name_match_p into la_get_symbol_name_cmp
- References: <1327906522-19961-1-git-send-email-brobecker@adacore.com>
On Mon, 30 Jan 2012 07:55:22 +0100, Joel Brobecker wrote:
> unless there are better naming suggestions?
Maybe "la_get_symbol_name_no_match"? As you note yourself:
> + Despite what the name might suggest, there is no ordering involved.
> + If the names do not match, any non-zero return value is correct.
> /* Implement the "la_get_symbol_name_match_p" language_defn method
^^^^^^^^^^^^^^^^^^^^^^^^^^
Forgotten unchanged string.
[...]
> - ada_get_symbol_name_match_p, /* la_get_symbol_name_match_p */
> + ada_get_symbol_name_cmp, /* la_get_symbol_name_match_p */
^^^^^^^^^^^^^^^^^^^^^^^^^^
Forgotten unchanged string. I did not grep the files outside of this diff.
Thanks,
Jan