This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc v3][4/6] Readlink as file I/O target operation


Only minor nits:

On 01/17/2012 07:47 PM, Ulrich Weigand wrote:
> +    /* Read value of symbolic link FILENAME on the remote target.  Return
> +       a null-terminated string allocated via xmalloc, or NULL if an error
> +       occurs (and set *REMOTE_ERRNO).  */
> +    char *(*to_fileio_readlink) (const char *filename, int *remote_errno);
> +

s/the remote target/the target/
s/REMOTE_ERRNO/TARGET_ERRNO/.
s/remote_errno/target_errno/.

I spotted several instances of this in this patch.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]