Re: [rfc v2][0/6] Remote /proc file access

[Pedro Alves <palves at redhat dot com>]

On 01/13/2012 06:13 PM, Ulrich Weigand wrote:

> Any further comments comments on this approach are appreciated!

I've been through the series, and it looks good to me.
Thanks a lot!  If this doesn't work out in the end, I'll certainly help
sort it out.

I've given a couple comments in reply to the patches directly.  I'm leaving
some general-ish comments here:

 - We could consider making "info proc" work with the default run
   target if the current target can't handle it, so that
   "info proc PID" works even when not debugging a process yet,
   like today.

 - It could be argued that the pid parsing should be kept at
   the target/gdbarch callbacks side (pass down `char *args'),
   so that we didn't have:

+  if (args && *args == '/')
+    tid = strtoul (args + 1, &args, 10);
+  else
+    tid = 0;

   in infcmd.c:info_proc_cmd_1 which is only needed by procfs.c.

But please, don't consider these comments blocking in any way.

Thanks again.
-- 
Pedro Alves