This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit] delete corefile.c:close_exec_file
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 04 Jan 2012 11:51:27 -0700
- Subject: Re: [commit] delete corefile.c:close_exec_file
- References: <m3zkeu9868.fsf@fleche.redhat.com> <20111218063648.GF21915@adacore.com> <m3hb0sv5ec.fsf@fleche.redhat.com> <20120104151730.GA2730@adacore.com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> Ha ha ha!
Indeed :)
Joel> Attached is the patch that I just checked in as obvious. Does it
Joel> simplify a bit your work?
Yes, I think it does, but there are still a lot of bfd_cache_close_all
calls to contend with. Maybe these hid the fact that close_exec_file
did nothing.
I imagine at least some of these calls are needed on some platforms.
I haven't tried to test this yet.
Some of the calls seem a bit weird. E.g., the one in
symbol_file_add_with_addrs_or_offsets, from this thread:
http://sourceware.org/ml/gdb-patches/2004-07/msg00439.html
I'm still thinking about what options we have.
Tom