This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Ignore data minimal symbols for breakpoint linespecs
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: brobecker at adacore dot com (Joel Brobecker)
- Cc: emachado at linux dot vnet dot ibm dot com (Edjunior Barbosa Machado), mark dot kettenis at xs4all dot nl (Mark Kettenis), gdb-patches at sourceware dot org
- Date: Tue, 3 Jan 2012 19:44:22 +0100 (CET)
- Subject: Re: [RFA] Ignore data minimal symbols for breakpoint linespecs
Joel Brobecker wrote:
> > excellent, I've tested it on ppc64 and it fixes all those regressions
> > I mentioned.
>
> Excellent. It would be nice to have someone else's feedback before
> I commit, as I am not very familiar with this sort of thing (I tend
> to have a simpler view of things, as the first patch demonstrated).
I was seeing the same regressions on ppc64, and the patch indeed
fixes them. I'm wondering whether this is best place to perform
this check, though -- maybe it might be better to label function
descriptor minsyms as mst_text to start with (or possibly some
new category) ...
But in the absence of such a solution, I'd still be in favor of
committing your patch as is, given that it fixes a serious
regression and doesn't look like it can make things worse.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com