Re: [patch] s390*: watchpoints regression [repost]

[Pedro Alves <alves dot ped at gmail dot com>]

On Saturday 17 December 2011 19:44:54, Jan Kratochvil wrote:
> On Sat, 17 Dec 2011 20:40:13 +0100, Pedro Alves wrote:
> > In the loop that runs through the shell, fork-child.c:startup_inferior,
> > nothing inserts breakpoints/watchpoints.  So nothing ends up
> > setting lwp->arch_private->debug_registers_changed, and so we should
> > not be setting DR_CONTROL to 0 for the wrapper shell.  Do you
> > actually see it happen?
> 
> I see it happenning.  [attached]

Ah, I forgot this:

static void
i386_linux_new_thread (struct lwp_info *lp)
{
  struct arch_lwp_info *info = XCNEW (struct arch_lwp_info);

  info->debug_registers_changed = 1;

  lp->arch_private = info;
}

Hmm.  I'm starting to think that the easiest is jut to
go back at not calling new_thread for the first thread.
Let me give that a try.

-- 
Pedro Alves