This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[obv] s390*: Fix build regression, remains execution regression


Hi Pedro,

this is the obvious part, checked in.

Unfortunately there is still a regression, it crashes during exec from the
wrapper->real inferior on mostly any program (kernel-2.6.32-220.el6.s390x):

61562 pts/1 T  \_ /root/jkratoch/redhat/archer-git/gdb/gdb -nx -x ./transcript.1
61568 pts/1 T      \_ /bin/bash -c exec /root/jkratoch/redhat/archer-git/gdb/testsuite/gdb.base/watchpoint-cond-gone

(gdb) run
Starting program: /root/jkratoch/redhat/archer-git/gdb/testsuite/gdb.base/watchpoint-cond-gone 
Couldn't retrieve watchpoint status: No such process.
Couldn't get registers: No such process.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2011-12/msg00175.html

--- src/gdb/ChangeLog	2011/12/17 06:14:44	1.13641
+++ src/gdb/ChangeLog	2011/12/17 09:43:53	1.13642
@@ -1,3 +1,9 @@
+2011-12-17  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	Fix build regression from the PR threads/10729 fix.
+	* s390-nat.c (s390_insert_watchpoint, s390_remove_watchpoint): Use LP,
+	not LP->PTID.
+
 2011-12-16  Andrey Smirnov  <andrew.smirnov@gmail.com>
 
 	* mi/mi-main.c (mi_cmd_list_thread_groups): Rename `optind' and
--- src/gdb/s390-nat.c	2011/12/14 17:20:31	1.36
+++ src/gdb/s390-nat.c	2011/12/17 09:43:53	1.37
@@ -532,7 +532,7 @@
   watch_base = area;
 
   ALL_LWPS (lp)
-    s390_fix_watch_points (lp->ptid);
+    s390_fix_watch_points (lp);
   return 0;
 }
 
@@ -560,7 +560,7 @@
   xfree (area);
 
   ALL_LWPS (lp)
-    s390_fix_watch_points (lp->ptid);
+    s390_fix_watch_points (lp);
   return 0;
 }
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]