This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Replace magic numbers with macros in gdbserver/tracepoint.c
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 12 Dec 2011 10:43:48 +0100
- Subject: Re: [patch] Replace magic numbers with macros in gdbserver/tracepoint.c
- References: <4EE5674B.7050205@codesourcery.com>
On Mon, 12 Dec 2011 03:30:35 +0100, Yao Qi wrote:
> - ipa_trace_buffer_ctrl_curr = (0x80000000
> + ipa_trace_buffer_ctrl_curr = ( GDBSERVER_UPDATED_FLUSH_COUNT_BIT
^ excessive space
therefore:
# + ipa_trace_buffer_ctrl_curr = (GDBSERVER_UPDATED_FLUSH_COUNT_BIT
> | (prev << 12)
> | counter
> | curr_tbctrl_idx);
I have verified the constants.
Thanks,
Jan