This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS: Avoid breakpoints in branch delay slots


>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> I am having doubts again, but I think we do require C90 to compile GDB.

We do.

Joel> It's C99 that is not mandatory yet (hence the use of gnulib for some of
Joel> the C99 headers). Based on that, can we consider that we're always going
Joel> to have a 64bit "long long"?

I think we can't.

If debugging a particular target needs a 64 bit type on the host, and
such a type isn't available, then there is just no way to do that
debugging.  But, this situation is already accounted for, see
ALL_64_TARGET_OBS in gdb/Makefile.in.

I think this setup is increasingly rare, though.

Joel> The code looks good to me. I will let you decide which version you
Joel> think is going to be better to maintain. I was just afraid that you
Joel> needed to know what the *target* address size was, in which case the
Joel> define would have been the wrong solution.

I didn't really read the thread, but I would much prefer following the
existing approach over adding more BFD64 checks, if possible.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]