This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] arm reversible : <phase_2_complete>

From: Yao Qi <yao at codesourcery dot com>
To: oza Pawandeep <oza dot pawandeep at gmail dot com>
Cc: Petr HluzÃn <petr dot hluzin at gmail dot com>, Tom Tromey <tromey at redhat dot com>, paawan oza <paawan1982 at yahoo dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, chandra krishnappa <chandra_roadking at yahoo dot com>
Date: Mon, 05 Dec 2011 07:45:45 +0800
Subject: Re: [PATCH] arm reversible : <phase_2_complete>
References: <998639.46560.qm@web112516.mail.gq1.yahoo.com> <CAK1A=4yYqH9mHuDVmMAD8d9y5X176240pxDr4Ac3bVs8p5jQhw@mail.gmail.com> <m3vcqieb48.fsf@fleche.redhat.com> <CAK1A=4wz=2uU71yFz39EdOMvrLEyR+dX9TEogJ6vRR2Pu4pDNw@mail.gmail.com> <CAK1A=4zrPC2WnP8_F+pF9djgxDsZJMu6hbVMVVZXvC-VoqOHjQ@mail.gmail.com> <m3hb1i95xn.fsf@fleche.redhat.com> <CAK1A=4xgZiBR=iWgo_AbUw2amVZstqyQ3L-M2wm6DWndSh16Cw@mail.gmail.com> <CAK1A=4xBYsQ129h7GmF+KyL_0oz09+Kr0a4A+X-ir41-=DVSug@mail.gmail.com> <CAC=yr6CVW+5gOXCpo_jC+ESxrFWUqb=DakDvbT5URsd+F8Y_ZA@mail.gmail.com> <CAK1A=4zVVw3Y2pVTQ4EZmwcLtQob-QUajTyaSWEk4YQM_9b=MA@mail.gmail.com> <CAK1A=4wQis+_YW=oWBtreGZsXDZfK=FbTQv5uHsb=1Kp15=0-w@mail.gmail.com> <4EDAD0EF.20405@codesourcery.com> <CAK1A=4yLcpXq02hTt7xHEkSj1Z_8jc5Ew_3DY1GzqzWu_u=8gg@mail.gmail.com> <CAK1A=4wT8UrgdaOPDDggvdHBMnEh9b1mNLnOko9s51EV1zTXEQ@mail.gmail.com> <4EDB877B.2050903@codesourcery.com> <CAK1A=4xXnD0f05zXhFDC_f_Z0kroR46r=L5HLnSeTJK7yU9oUg@mail.gmail.com>

On 12/05/2011 01:00 AM, oza Pawandeep wrote:
> 	(struct insn_decode_record): New Structure. arm insn record

ChangeLog entry can not be a sentence, but it should be ended with "."
We can say "New structure for arm insn record" or just "New".

> 	(REG_ALLOC): New Macros. use it for reg allocations

"New macro for reg allocations."

> 	(MEM_ALLOC): New Macros. use it for memory allocations

"New macro for memory allocations."

The rest of ChangeLog looks right to me, so I don't have any other
comments on ChangeLog.

-- 
Yao (éå)

Follow-Ups:
- Re: [PATCH] arm reversible : <phase_2_complete>
  - From: oza Pawandeep

References:
- Re: [PATCH] arm reversible : <phase_2_complete>
  - From: Tom Tromey
- Re: [PATCH] arm reversible : <phase_2_complete>
  - From: oza Pawandeep
- Re: [PATCH] arm reversible : <phase_2_complete>
  - From: oza Pawandeep
- Re: [PATCH] arm reversible : <phase_2_complete>
  - From: Petr HluzÃn
- Re: [PATCH] arm reversible : <phase_2_complete>
  - From: oza Pawandeep
- Re: [PATCH] arm reversible : <phase_2_complete>
  - From: oza Pawandeep
- Re: [PATCH] arm reversible : <phase_2_complete>
  - From: Yao Qi
- Re: [PATCH] arm reversible : <phase_2_complete>
  - From: oza Pawandeep
- Re: [PATCH] arm reversible : <phase_2_complete>
  - From: oza Pawandeep
- Re: [PATCH] arm reversible : <phase_2_complete>
  - From: Yao Qi
- Re: [PATCH] arm reversible : <phase_2_complete>
  - From: oza Pawandeep

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]