This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/ping] 12843

On 11/10/2011 10:12 AM, Joel Brobecker wrote: 
-	  || p[0] == '\t'
-	  || (p[0] == ':')
+	  || p[0] == '\t' || p[0] == ':'


I wish reformatting changes like this were made separately.
Usually, they can even be checked in under the obvious rule...
In this case, not so sure - I like the previous formatting better,
because each branch of the multiple-or was on its own line.
But don't change it on my account, it's not terribly important.


Agh! Jan noticed this, too, and I totally forgot about it. My guess is that I actually *did* have a change there at one time, but "reverted" it (to this reformatted entry).

I'll wipe that out. I am also going to try to run the MinGW test suite on gdb before committing. That should be fun.

Keith

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]