This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 6/8] gdbserver - Install tracepoint when tracing is running


On 11/08/2011 04:20 PM, Eli Zaretskii wrote:

>> +	 TPOINT is inserted at the last of them.
> 
> "inserted at the last of them" is not clear.  I would suggest using
> "before" or "after".  Or maybe "at the highest address" if you mean
> "at address" (I don't really understand the meaning of what the code
> does.)
> 

What I want to describe is there have been three, for example,
tracepoints setting at the same address, and the forth is to be set at
the same place as well, and insert the forth into linked list.  What I
meant in comment is "insert the forth tracepoint after these three
existing tracepoints", and of course, there may be other tracepoints, at
higher address, after them in the list.

How about "TPOINT is inserted after all the tracepoints which are set at
the same address"?

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]